Skip to content

Show outline ring on map marker hover instead of selected pin#1788

Open
alisa911 wants to merge 4 commits into
mainfrom
120626_1
Open

Show outline ring on map marker hover instead of selected pin#1788
alisa911 wants to merge 4 commits into
mainfrom
120626_1

Conversation

@alisa911

Copy link
Copy Markdown
Contributor

No description provided.

@alisa911

Copy link
Copy Markdown
Contributor Author

#1297

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates map-hover behavior so that hovering markers on the map shows a lightweight outline ring instead of swapping the marker to the full “selected pin” UI, and adds an “outside-of-viewport” direction pin for hovered search results that are off-screen.

Changes:

  • Add hover-outline rendering and direction-pin rendering in marker selection services and marker icon builders.
  • Update hover selection logic to distinguish map-origin hover (hoverFromMap) vs list-origin hover, and to show a direction pin when a hovered search result is outside the visible map.
  • Minor related adjustments: turn-point z-index in NavigationLayer, and new visible-rect helpers in MapStateLayer.

Reviewed changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
map/src/util/hooks/map/useSelectMarkerOnMap.js Switches map-origin hover to outline ring; adds off-screen direction pin logic for search hover.
map/src/map/util/MarkerSelectionService.js Adds applyHoverOutline and applyDirectionPin utilities used by hover behavior.
map/src/map/util/Clusterizer.js Marks tooltip hover as map-origin (hoverFromMap: true).
map/src/map/markers/SelectedPinMarker.js Introduces new divIcon builders for hover outline and direction pin icons.
map/src/map/layers/NavigationLayer.js Raises turn dot markers via zIndexOffset; minor optional chaining cleanup.
map/src/map/layers/MapStateLayer.js Adds pixel-rect visibility helpers (visibleMapRectPx, isOutsideVisibleMap).
map/src/assets/map/ic_pin_circle_outisde_color.svg New direction-pin asset (color layer).
map/src/assets/map/ic_pin_circle_outisde_light.svg New direction-pin asset (light layer).
map/src/assets/map/ic_pin_circle_outisde_stroke.svg New direction-pin asset (stroke layer).
map/src/assets/map/hover_point_circle.svg New hover-outline asset (circle).
map/src/assets/map/hover_point_square.svg New hover-outline asset (square).
map/src/assets/map/hover_point_octagon.svg New hover-outline asset (octagon/hex).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js
Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js
Comment thread map/src/map/markers/SelectedPinMarker.js Outdated
@alisa911 alisa911 linked an issue Jun 12, 2026 that may be closed by this pull request
28 tasks
@alisa911 alisa911 requested a review from RZR-UA June 12, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't see where object is located by link

2 participants