Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates map-hover behavior so that hovering markers on the map shows a lightweight outline ring instead of swapping the marker to the full “selected pin” UI, and adds an “outside-of-viewport” direction pin for hovered search results that are off-screen.
Changes:
- Add hover-outline rendering and direction-pin rendering in marker selection services and marker icon builders.
- Update hover selection logic to distinguish map-origin hover (
hoverFromMap) vs list-origin hover, and to show a direction pin when a hovered search result is outside the visible map. - Minor related adjustments: turn-point z-index in
NavigationLayer, and new visible-rect helpers inMapStateLayer.
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| map/src/util/hooks/map/useSelectMarkerOnMap.js | Switches map-origin hover to outline ring; adds off-screen direction pin logic for search hover. |
| map/src/map/util/MarkerSelectionService.js | Adds applyHoverOutline and applyDirectionPin utilities used by hover behavior. |
| map/src/map/util/Clusterizer.js | Marks tooltip hover as map-origin (hoverFromMap: true). |
| map/src/map/markers/SelectedPinMarker.js | Introduces new divIcon builders for hover outline and direction pin icons. |
| map/src/map/layers/NavigationLayer.js | Raises turn dot markers via zIndexOffset; minor optional chaining cleanup. |
| map/src/map/layers/MapStateLayer.js | Adds pixel-rect visibility helpers (visibleMapRectPx, isOutsideVisibleMap). |
| map/src/assets/map/ic_pin_circle_outisde_color.svg | New direction-pin asset (color layer). |
| map/src/assets/map/ic_pin_circle_outisde_light.svg | New direction-pin asset (light layer). |
| map/src/assets/map/ic_pin_circle_outisde_stroke.svg | New direction-pin asset (stroke layer). |
| map/src/assets/map/hover_point_circle.svg | New hover-outline asset (circle). |
| map/src/assets/map/hover_point_square.svg | New hover-outline asset (square). |
| map/src/assets/map/hover_point_octagon.svg | New hover-outline asset (octagon/hex). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.