arch: map OCI platform architecture to GOARCH#2315
Open
mochaaP wants to merge 1 commit into
Open
Conversation
Partially fixes osbuild#2306 Signed-off-by: Zephyr Lykos <git@mochaa.ws>
Member
|
Thank you and this will need osbuild stage changes if we want to support variant as well? I've opened: osbuild/osbuild#2431 so that it can be ready in the future. I think for this PR subarches can be a followup; cc @achilleas-k @lzap? The two failed CI tests are flakes, I'll look into them. |
Contributor
|
Yeah I think subarches can be ignored for now, our environments are typically either x86_64 v1 or v3 (RHEL10). Well, unless Fedora does not move forward with some complicated variant build solution... I'd just drop it from the patch for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #2306.
TODO: make variants (arm/v5,v6,v7 arm64/v8... ppc64/power8,power9 riscv64/rva20u64,rva22u64,rva23u64 amd64/v1,v2,v3,v4) available so RHEL9+ can correctly map to amd64/v3, otherwise SIGILL if you have non-v3 builders in the fleet that can get scheduled
TODO: how does this map to RPM subarchs?