Skip to content

fedora: drop no_timer_check leftover#2282

Open
lzap wants to merge 1 commit into
osbuild:mainfrom
lzap:notimer2
Open

fedora: drop no_timer_check leftover#2282
lzap wants to merge 1 commit into
osbuild:mainfrom
lzap:notimer2

Conversation

@lzap
Copy link
Copy Markdown
Contributor

@lzap lzap commented Mar 27, 2026

This was removed in 479768c but somehow slipped back in, or I missed it.

@lzap lzap requested a review from a team as a code owner March 27, 2026 09:44
@lzap lzap requested review from bcl, croissanne and supakeen March 27, 2026 09:44
supakeen
supakeen previously approved these changes Mar 27, 2026
@supakeen
Copy link
Copy Markdown
Member

AFAIK @croissanne re-introduced it so let's await her opinion too.

avitova
avitova previously approved these changes Apr 21, 2026
Copy link
Copy Markdown
Contributor

@avitova avitova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, I think there was enough time to step in. Let's remove this.

@lzap
Copy link
Copy Markdown
Contributor Author

lzap commented Apr 21, 2026

@croissanne ?

@croissanne
Copy link
Copy Markdown
Member

This is fine to remove if Simon is ok with it. I added this when adding systemd.firstboot=0. At that point I just copied over all kernel options from the existing fedora cloud images.

But maybe we want to actually have the cloud-* images have the same as fedora, meaning keeping this option for them. And for the generic-* images we can drop it? Idk, wdyt @supakeen

@supakeen
Copy link
Copy Markdown
Member

This is fine to remove if Simon is ok with it. I added this when adding systemd.firstboot=0. At that point I just copied over all kernel options from the existing fedora cloud images.

But maybe we want to actually have the cloud-* images have the same as fedora, meaning keeping this option for them. And for the generic-* images we can drop it? Idk, wdyt @supakeen

This change only affects generic--images which is why I previously approved it 🙂

@lzap lzap dismissed stale reviews from avitova and supakeen via 6842230 April 29, 2026 14:06
@lzap
Copy link
Copy Markdown
Contributor Author

lzap commented Apr 29, 2026

Allright we have a go! Rebased.

@lzap lzap requested review from avitova and supakeen April 29, 2026 14:06
supakeen
supakeen previously approved these changes Apr 29, 2026
brlane-rht
brlane-rht previously approved these changes Apr 30, 2026
Copy link
Copy Markdown
Contributor

@brlane-rht brlane-rht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Schutzbot let's merge this!

@brlane-rht brlane-rht enabled auto-merge April 30, 2026 23:47
@lzap
Copy link
Copy Markdown
Contributor Author

lzap commented May 4, 2026

Not sure what to do with

Run ./test/scripts/setup-osbuild-repo
Checking URL http://osbuild-composer-repos.s3-website.us-east-2.amazonaws.com/osbuild/fedora-44/x86_64/31bf3c482238aa4cd3c57be6cf6b3a731788a9f0/repodata/repomd.xml
HTTP Error 403: Forbidden

@supakeen
Copy link
Copy Markdown
Member

supakeen commented May 4, 2026

Not sure what to do with

Run ./test/scripts/setup-osbuild-repo
Checking URL http://osbuild-composer-repos.s3-website.us-east-2.amazonaws.com/osbuild/fedora-44/x86_64/31bf3c482238aa4cd3c57be6cf6b3a731788a9f0/repodata/repomd.xml
HTTP Error 403: Forbidden

Rebase on top of: #2322 or wait until I set up the f44/f45 runners and RPM builds.

This was removed in 479768c but somehow
slipped back in, or I missed it.
@achilleas-k
Copy link
Copy Markdown
Member

Rebased and fixed conflics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants