Document steps to create a computeinstance#30
Document steps to create a computeinstance#30achuzhoy wants to merge 1 commit intoosac-project:mainfrom
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis pull request adds a new developer guide ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
guides/developer/computeinstance-guide.md (1)
101-101: ⚡ Quick winPin the VM image to a stable version tag.
The example uses
:latest, which is non-deterministic and can break over time. Official KubeVirt documentation and the containerdisks repository use version tags (e.g.,quay.io/containerdisks/fedora:43) to ensure reproducibility. Update to a tested, specific version tag or image digest.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@guides/developer/computeinstance-guide.md` at line 101, The VM image is using a non-deterministic tag (`source_ref: quay.io/containerdisks/fedora:latest`); change the `source_ref` value to a pinned image tag or digest (for example `quay.io/containerdisks/fedora:43` or `quay.io/containerdisks/fedora@sha256:<digest>`) so the example is reproducible, and update any surrounding example text that references `:latest` to reflect the pinned tag/digest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@guides/developer/computeinstance-guide.md`:
- Around line 105-121: Replace the insecure plaintext credentials in the
user_data cloud-init example by switching to SSH key authentication or a
mandatory secret placeholder: remove the hard-coded "user: kni" and "password:
redhat" entries in the user_data block and instead show an ssh_authorized_keys
template or refer to a required secret variable (with guidance to rotate and
inject per-deployment); update the example text and any occurrences (also at
lines referenced by the reviewer) to explicitly instruct using ssh keys or a
strong secret placeholder and include rotation guidance rather than publishing
reusable plaintext credentials.
---
Nitpick comments:
In `@guides/developer/computeinstance-guide.md`:
- Line 101: The VM image is using a non-deterministic tag (`source_ref:
quay.io/containerdisks/fedora:latest`); change the `source_ref` value to a
pinned image tag or digest (for example `quay.io/containerdisks/fedora:43` or
`quay.io/containerdisks/fedora@sha256:<digest>`) so the example is reproducible,
and update any surrounding example text that references `:latest` to reflect the
pinned tag/digest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4e6d9856-dd94-42d9-91ff-bb3d947ab8a6
📒 Files selected for processing (1)
guides/developer/computeinstance-guide.md
The guide aims with creating a computeinstance on a subnet. Signed-off-by: Alexander Chuzhoy <achuzhoy@redhat.com>
The guide aims with creating a computeinstance on
a subnet.
Summary by CodeRabbit