Allow pnpm to install packages#1143
Open
jimohalloran wants to merge 1 commit into
Open
Conversation
Member
|
@jimohalloran Thank you for your contribution! |
Member
|
internal ticket - BB-27327 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the transition from npm to pnpm the changeover from running
npm citopnpm i --lockfile-onlyresulted in incorrect behaviour.The
npm cicommand downloaded and installed packages at the specific versions as specified in the lockfile.pnpm i --lockfile-onlyon the other hand does not download dependencies, it just updates the lockfile. This is not a substitute fornpm ci.What we want instead of
pnpm i --frozen-lockfileas this will download and install exactly the dependencies specified in the lock file, which is equivelent to thenpm cicommand.The problem with using
--lockfile-onlyis that when trying to deploy outside of dev or CI environments (--frozen-lockfileis by default on in CI) no npm dependencies are downloaded or installed, which results in a broken system.This patch updates the command line used by the composer helper script accordingly.