zpool/zfs: accept --help, -h, -? after a subcommand#18541
Open
chrislongros wants to merge 1 commit into
Open
Conversation
behlendorf
reviewed
May 14, 2026
behlendorf
reviewed
May 15, 2026
Print the short usage instead of "invalid option". Signed-off-by: Christos Longros <chris.longros@gmail.com>
62ca5fb to
aeec515
Compare
Contributor
|
It looks like we a few consistent failures which will need to be looked at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zpool <subcommand> --help(and-h,-?) printsinvalid option '-'followed by the subcommand's usage line, instead of showing help. Same bug for every subcommand. First reported as issue 1 in #17603.Description
Catch
--help,-h, and-?after a subcommand, look it up in the command table, and print its short usage. Unknown subcommands fall through to the existing "unrecognized command" error.How Has This Been Tested?
zpool scrub|checkpoint|create|status|attach|list --help|-h|-?on:Types of changes
Checklist