additional error checking in ping script#553
additional error checking in ping script#553clutch2sft wants to merge 1 commit intoopenwisp:masterfrom
Conversation
nemesifier
left a comment
There was a problem hiding this comment.
the file is getting entirely rewritten, I am not sure why, can you please fix that? We cannot perform a proper review if we do not see what exactly is getting changed.
I can see the individual changes in two commits in the commits tab. If you can't see those there I can copy into this conversation. Thanks! Ggg |
nemesifier
left a comment
There was a problem hiding this comment.
the file is getting entirely rewritten, I am not sure why, can you please fix that? We cannot perform a proper review if we do not see what exactly is getting changed.
I can see the individual changes in two commits in the commits tab. If you can't see those there I can copy into this conversation. Thanks! Ggg
Thanks for explaining.
The second commit seems to be causing issues, could you please remove that commit and add the change that was meant to be in that commit to the previous one using git commig --amend? That will update the first commit.
e4625e2 to
2ff0723
Compare
|
I think the commit issue is resolved. Thanks. |
Made command build "more correct"
Argument Splitting: Usually, each argument and the command itself are separate elements in the list. If any of the flags or options require values (like -c 5), those should usually also be separate elements in the list.
Implement try catch block in _command to catch any errors from the shell.
Returning the commands exit code.
Check exit code and if it is NOT zero(0)=all the pinged hosts are reachable -or- one(1)=Some hosts were unreachable. Then raise an error to improve (speed up) troubleshooting.
Checks: