Skip to content

wip: Debug k8s 1.35 rebase#621

Closed
ingvagabund wants to merge 11 commits into
openshift:mainfrom
ingvagabund:debug-k8s-1.35-rebase
Closed

wip: Debug k8s 1.35 rebase#621
ingvagabund wants to merge 11 commits into
openshift:mainfrom
ingvagabund:debug-k8s-1.35-rebase

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

/hold

To extend debugging of #616 without setting AllowWatchBookmarks=true on the server side

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 792dd277-ad3d-40c8-9537-0d040486420c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 16, 2026
@openshift-ci openshift-ci Bot requested review from abhgupta and adambkaplan March 16, 2026 21:37
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund ingvagabund force-pushed the debug-k8s-1.35-rebase branch from c990210 to df60e1a Compare March 17, 2026 11:14
@ingvagabund ingvagabund deleted the debug-k8s-1.35-rebase branch March 18, 2026 11:18
@ingvagabund ingvagabund restored the debug-k8s-1.35-rebase branch March 20, 2026 13:21
@ingvagabund ingvagabund reopened this Mar 20, 2026
@ingvagabund ingvagabund force-pushed the debug-k8s-1.35-rebase branch from df60e1a to e9ce66d Compare March 20, 2026 13:57
@ingvagabund
Copy link
Copy Markdown
Member Author

/retest-required

@ingvagabund ingvagabund force-pushed the debug-k8s-1.35-rebase branch 2 times, most recently from 03c5764 to bd7293c Compare March 23, 2026 21:16
@ingvagabund ingvagabund force-pushed the debug-k8s-1.35-rebase branch from bd7293c to 80f374e Compare March 24, 2026 08:44
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2026

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/go-verify-deps 80f374e link true /test go-verify-deps
ci/prow/unit 80f374e link true /test unit
ci/prow/verify-deps 80f374e link true /test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ingvagabund ingvagabund deleted the debug-k8s-1.35-rebase branch March 24, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant