OCPBUGS-84950: Try to deflake the deployment test by refreshing the rv used for watch

[xueqzhan]

/hold

Testing for now.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Summary by CodeRabbit

• Tests
  • Enhanced Deployment lifecycle testing to use more current resource versions for subsequent watch operations, improving test reliability and consistency.

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-84950, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/hold

Testing for now.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@xueqzhan: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• eb7f6ec|Try to deflake the deployment test by refreshing the rv used for watch: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[xueqzhan]

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

[openshift-ci]

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c550e280-47d3-11f1-873e-ed7e4ee181cb-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xueqzhan
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4f71ee7e-3a83-40a3-8153-c8faad4c1432

📥 Commits

Reviewing files that changed from the base of the PR and between 2447118 and eb7f6ec.

📒 Files selected for processing (1)

• test/e2e/apps/deployment.go

---

Walkthrough

The Deployment lifecycle test is enhanced to refresh the deploymentsList watch ResourceVersion after verifying replicas are Ready. The test re-lists Deployments using the same label selector, updating the list object and error state with the fresher resource version for use in subsequent watch operations.

Changes

Deployment Watch ResourceVersion Refresh

Layer / File(s)	Summary
Test Enhancement test/e2e/apps/deployment.go	After the initial Deployment readiness check, the test re-lists Deployments to obtain a current ResourceVersion before proceeding to patch-based watch assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the specific change: refreshing the resourceVersion used for watch operations in the deployment test to reduce flakiness, which matches the actual code change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test titles in test/e2e/apps/deployment.go are literal, static strings without dynamic formatting, concatenation, or runtime values.
Test Structure And Quality	✅ Passed	The code modification demonstrates sound test quality practices including single responsibility, appropriate setup/cleanup patterns, proper timeout implementation, meaningful assertion messages, and consistency with codebase patterns.
Microshift Test Compatibility	✅ Passed	The PR modifies an existing conformance test by adding code to refresh the Deployment list's resourceVersion, but does not add new Ginkgo e2e test declarations.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies existing deployment lifecycle test by adding ResourceVersion refresh code but does not introduce new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request modifies only test infrastructure code in test/e2e/apps/deployment.go, adding a resource version refresh step. No deployment manifests, operator code, or controllers are modified, and no topology-aware scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	Added code in deployment.go contains only API calls within test functions with no stdout-writing operations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only modifies an existing test in deployment.go by refreshing watch ResourceVersion, without adding any new Ginkgo e2e test definitions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-84950, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/hold

Testing for now.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Summary by CodeRabbit

• Tests
• Enhanced Deployment lifecycle testing to use more current resource versions for subsequent watch operations, improving test reliability and consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@xueqzhan: This PR was included in a payload test run from openshift/origin#31121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/acd1d010-4824-11f1-96d7-fccd400c269e-0

[openshift-ci]

@xueqzhan: This PR was included in a payload test run from openshift/origin#31121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9be1f5c0-4895-11f1-8447-ace778bf3dd9-0

[openshift-ci]

@xueqzhan: This PR was included in a payload test run from openshift/origin#31121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f10be20-48ae-11f1-8d5a-8f82a3ed3ba1-0