Revert "NO-JIRA: Disable WatchList feature gate due to the missing support of Project watch"

[ricardomaraschini]

openshift/openshift-apiserver#633 introduces support for the new WatchList semantics.

Reverts #667

Summary by CodeRabbit

• Refactor
  • Simplified feature-gate observation setup by removing unnecessary wrapper implementations and streamlining the initialization flow for improved code maintainability.

[openshift-ci-robot]

@ricardomaraschini: This pull request explicitly references no jira issue.

Details

In response to this:

openshift/openshift-apiserver#633 introduces support for the new WatchList semantics.

Reverts #667

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6edbd013-b879-46bd-a3c2-73ed4a156bde

📥 Commits

Reviewing files that changed from the base of the PR and between 15fd39f and 156cf98.

📒 Files selected for processing (1)

• pkg/operator/configobservation/configobservercontroller/observe_config_controller.go

---

Walkthrough

The controller's feature-gate observation setup removes custom wrapper logic that previously overrode the WatchList feature gate behavior. The featureGateAccessor is now passed directly to the observation function instead of being wrapped, eliminating related wrapper types and helper functions.

Changes

Cohort / File(s)	Summary
Feature Gate Observation Refactoring pkg/operator/configobservation/configobservercontroller/observe_config_controller.go	Removed custom wrapper types and logic that augmented KnownFeatures and forced Enabled behavior for the WatchList feature gate. The accessor is now passed directly without wrapping. Unused imports supporting the removed wrappers are deleted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: reverting a previous commit that disabled the WatchList feature gate, which aligns with the code changes removing the wrapper logic.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only observe_config_controller.go (implementation file), not test files. No Ginkgo test files or test names are affected.
Test Structure And Quality	✅ Passed	PR modifies non-test controller code only; no Ginkgo test files present, making this quality check inapplicable.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it only modifies controller configuration by removing wrapper code and simplifying feature gate handling.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The Single Node OpenShift (SNO) test compatibility check is not applicable to this pull request because it contains no new Ginkgo e2e tests—only operational code changes reverting feature gate disablement logic.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request refactors feature gate handling in observe_config_controller.go without introducing topology-altering deployment configurations.
Ote Binary Stdout Contract	✅ Passed	Changes remove wrapper types and helper functions for feature gate observation without introducing stdout writes at process level.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it only modifies production controller code.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ricardomaraschini]

This is, at this stage, a test PR.

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment