MON-4556: Add transport label to CUDN telemetry allowlist#2903
MON-4556: Add transport label to CUDN telemetry allowlist#2903mattedallo wants to merge 1 commit into
Conversation
Add transport=~"Geneve|NoOverlay|EVPN|Localnet" to the cluster_user_defined_networks allowlist entry so the transport dimension added by the upstream ovn-kubernetes metric is explicitly bounded in the telemetry pipeline. Depends on CNO PR openshift/cluster-network-operator#2978 which updates the recording rule to include transport in max by(). Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
@mattedallo: This pull request references MON-4556 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Holding for openshift/cluster-network-operator#2978 — the CMO allowlist requires |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes consistently add a Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test all |
|
@mattedallo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattedallo, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
transport=~"Geneve|NoOverlay|EVPN|Localnet"to thecluster_user_defined_networkstelemetry allowlist entry so the transport dimension is explicitly bounded in the telemetry pipeline.Depends on:
transportto the recording rule'smax by())transportlabel to the raw metric in ovn-k)Related: