Skip to content

MON-4556: Add transport label to CUDN telemetry allowlist#2903

Draft
mattedallo wants to merge 1 commit into
openshift:mainfrom
mattedallo:evpn-metrics-transport-allowlist
Draft

MON-4556: Add transport label to CUDN telemetry allowlist#2903
mattedallo wants to merge 1 commit into
openshift:mainfrom
mattedallo:evpn-metrics-transport-allowlist

Conversation

@mattedallo
Copy link
Copy Markdown

Add transport=~"Geneve|NoOverlay|EVPN|Localnet" to the cluster_user_defined_networks telemetry allowlist entry so the transport dimension is explicitly bounded in the telemetry pipeline.

Depends on:

Related:

Add transport=~"Geneve|NoOverlay|EVPN|Localnet" to the
cluster_user_defined_networks allowlist entry so the transport
dimension added by the upstream ovn-kubernetes metric is explicitly
bounded in the telemetry pipeline.

Depends on CNO PR openshift/cluster-network-operator#2978 which
updates the recording rule to include transport in max by().

Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2026

@mattedallo: This pull request references MON-4556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add transport=~"Geneve|NoOverlay|EVPN|Localnet" to the cluster_user_defined_networks telemetry allowlist entry so the transport dimension is explicitly bounded in the telemetry pipeline.

Depends on:

Related:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mattedallo
Copy link
Copy Markdown
Author

/hold

Holding for openshift/cluster-network-operator#2978 — the CMO allowlist requires transport to be present on the recording rule output.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 214be6bd-2953-4460-adc6-476a2b814a65

📥 Commits

Reviewing files that changed from the base of the PR and between a2d7c76 and cb321ca.

📒 Files selected for processing (4)
  • Documentation/data-collection.md
  • Documentation/sample-metrics.md
  • Documentation/telemetry/telemeter_query
  • manifests/0000_50_cluster-monitoring-operator_04-config.yaml

📝 Walkthrough

Walkthrough

The changes consistently add a transport label dimension to the telemetry metric selector cluster:ovnkube_clustermanager_cluster_user_defined_networks:max across documentation and manifest files. The transport label is configured with regex filter values Geneve|NoOverlay|EVPN|Localnet. Documentation comments and sample query examples are updated to reflect this new label breakdown across role, topology, and transport type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title 'MON-4556: Add transport label to CUDN telemetry allowlist' accurately summarizes the main change—adding a transport label dimension to the telemetry configuration.
Description check ✅ Passed The description clearly explains the change (adding transport label filter), its purpose (bounding the transport dimension in telemetry), and includes relevant dependencies and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies documentation and configuration files without any Ginkgo test files or test code patterns.
Test Structure And Quality ✅ Passed Pull request contains only documentation and manifest configuration changes with no modifications to Ginkgo test files.
Microshift Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. Changes are limited to documentation files and Kubernetes configuration manifests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request does not add or modify any Ginkgo e2e tests. Changes are exclusively to documentation and Kubernetes manifests updating telemetry metrics configuration.
Topology-Aware Scheduling Compatibility ✅ Passed Changes are limited to telemetry metric selectors and Prometheus query configurations in ConfigMap; no pod scheduling constraints or topology-dependent workload logic introduced.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is designed to prevent non-JSON stdout emissions from executable test code at the process level. This PR contains only documentation and configuration file changes with no modifications to executable code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The PR consists entirely of documentation updates and manifest configuration changes related to adding a transport label dimension to telemetry metric selectors.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattedallo
Copy link
Copy Markdown
Author

/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@mattedallo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions cb321ca link false /test versions
ci/prow/e2e-aws-ovn-upgrade cb321ca link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattedallo, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants