WIP: CNTRLPLANE-3395: Lower maximum allowed etcd quota from 32 to 16GiB

[dusk125]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@dusk125: This pull request references CNTRLPLANE-3395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @dusk125! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change reduces the maximum allowed value for the backendQuotaGiB field in the Etcd CRD from 32 to 16. The modification is applied across the Go type definition in operator/v1/types_etcd.go and propagated to all CRD manifest variations including CustomNoUpgrade, DevPreviewNoUpgrade, and TechPreviewNoUpgrade schemas. The default value remains 8 and the minimum value remains 8. Updated validation constraints and description text reflect the new upper bound constraint.

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Test file contains invalid tests. PR reduces max from 32 to 16, but tests still expect 32 GiB and 20 GiB to succeed. Error messages still reference max 32.	Remove test cases at lines 42-58 (20 GiB) and 59-75 (32 GiB). Update expected error messages to reference max 16 instead of 32.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset.	Add a pull request description explaining the motivation for lowering the etcd quota maximum and any relevant context or testing performed.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: lowering the maximum allowed etcd quota from 32 to 16GiB, which matches the changeset modifications across all four files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in EtcdBackendQuota.yaml are stable and static without dynamic information like UUIDs, timestamps, or pod names.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this PR. The changes consist only of type definitions, CRD manifests, and test fixture updates. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies Go type definitions and CRD manifest files for etcd validation. SNO test compatibility check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates CRD validation for etcd backendQuotaGiB field (max 32→16 GiB). No scheduling constraints, pod affinity rules, or topology-specific logic added.
Ote Binary Stdout Contract	✅ Passed	PR modifies only CRD validation schemas and comments. No process-level code changes (main, init, TestMain, BeforeSuite) or stdout writes that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. Changes are limited to Go types, CRD manifests, and YAML test specs. Check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@operator/v1/types_etcd.go`:
- Around line 45-49: The BackendQuotaGiB validation in operator/v1/types_etcd.go
was lowered to a maximum of 16, which breaks tests and existing CRs; update the
test suite operator/v1/tests/etcds.operator.openshift.io/EtcdBackendQuota.yaml
by removing or changing the case "Should be able to create with 32
BackendQuotaGiB" (and any other cases using values >16) and update expected
validation error strings to reference max 16 instead of 32 for tests that assert
failure; after adjusting tests, ensure you either document/implement a CRD
versioning/conversion or migration strategy for existing Etcd resources that may
have BackendQuotaGiB ≥17 so cluster upgrades remain safe (verify compliance with
OpenShift CRD upgrade rules).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e01d9449-15f8-4b64-908f-fb28441d8061

📥 Commits

Reviewing files that changed from the base of the PR and between 5262534 and 422ddb6.

⛔ Files ignored due to path filters (6)

• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*
• operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.featuregated-crd-manifests/etcds.operator.openshift.io/EtcdBackendQuota.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*

📒 Files selected for processing (4)

• operator/v1/types_etcd.go
• payload-manifests/crds/0000_12_etcd_01_etcds-CustomNoUpgrade.crd.yaml
• payload-manifests/crds/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml

[openshift-ci]

@dusk125: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration	422ddb6	link	true	/test integration
ci/prow/verify-crdify	422ddb6	link	true	/test verify-crdify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

Are we able to check to telemetry data to see what the field currently has set for this value? Has anyone tried increasing this value above 16 presently?

[dusk125]

Are we able to check to telemetry data to see what the field currently has set for this value? Has anyone tried increasing this value above 16 presently?

This is in Tech Preview which we're currently trying to get to GA. Our internal testing has shown that, currently, 32GiB is too large and will very likely cause cluster instability. Also, using the logic that it's easier to increase the maximum later, than it is to ship this at 32 and later limit the maximum to 16

[JoelSpeed]

Ack, missed that this was TP, in which case all good

Any reason this is still in WIP?

[dusk125]

Ack, missed that this was TP, in which case all good

Any reason this is still in WIP?

No problem! Yeah we're still aligning that this is what we want to do, and leaving this unmerged allows us to test up to the 32GiB to validate cluster stability (and see if we can indeed offer up to 32)

[dusk125]

@JoelSpeed am I correct in assuming that increasing this maximum constraint in a minor or patch release of openshift is not a big deal? Meaning if we were to ship 16, and later we validate that 32 is stable, we could, without disruption, update this api constraint?

[JoelSpeed]

@JoelSpeed am I correct in assuming that increasing this maximum constraint in a minor or patch release of openshift is not a big deal? Meaning if we were to ship 16, and later we validate that 32 is stable, we could, without disruption, update this api constraint?

Yes, we generally allow relaxing validation in cases like this