Skip to content

feat: add AlibabaCloud-AutoNLBs-V3 network plugin#335

Open
chrisliu1995 wants to merge 2 commits intoopenkruise:masterfrom
chrisliu1995:feature/auto-nlbs-v3
Open

feat: add AlibabaCloud-AutoNLBs-V3 network plugin#335
chrisliu1995 wants to merge 2 commits intoopenkruise:masterfrom
chrisliu1995:feature/auto-nlbs-v3

Conversation

@chrisliu1995
Copy link
Copy Markdown
Member

  • Add AutoNLBsV3Plugin implementation (auto_nlbs_v3.go)
  • Add unit tests for V3 plugin (auto_nlbs_v3_test.go)
  • V3 plugin uses stateless Service pool binding from NLBPool CR
  • Supports dynamic port allocation via label-based optimistic locking

- Add AutoNLBsV3Plugin implementation (auto_nlbs_v3.go)
- Add unit tests for V3 plugin (auto_nlbs_v3_test.go)
- V3 plugin uses stateless Service pool binding from NLBPool CR
- Supports dynamic port allocation via label-based optimistic locking
@kruise-bot kruise-bot requested review from FillZpp and zmberg April 24, 2026 04:12
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 68.05556% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.95%. Comparing base (c6c7386) to head (6e11823).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cloudprovider/alibabacloud/auto_nlbs_v3.go 68.05% 53 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   40.77%   41.95%   +1.17%     
==========================================
  Files         112      113       +1     
  Lines       12549    12786     +237     
==========================================
+ Hits         5117     5364     +247     
+ Misses       7020     6989      -31     
- Partials      412      433      +21     
Flag Coverage Δ
unittests 41.95% <68.05%> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants