adding unit test for pkg/client/registry.go#272
adding unit test for pkg/client/registry.go#272Prakhar-Shankar wants to merge 1 commit intoopenkruise:masterfrom
pkg/client/registry.go#272Conversation
Signed-off-by: Prakhar-Shankar <prakharshankar247@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 27.65% 31.30% +3.65%
==========================================
Files 94 96 +2
Lines 10450 11327 +877
==========================================
+ Hits 2890 3546 +656
- Misses 7358 7535 +177
- Partials 202 246 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@chrisliu1995 can you please review this PR, thanks :) |
Title:
Add unit tests for client/registry.go
Description:
This PR adds unit tests for the pkg/client/registry.go file to improve coverage and ensure the correctness of the NewRegistry, GetGenericClient, and GetGenericClientWithName functions.
Fixes issue #266
Tests include:
These tests help validate basic functionality and ensure expected behavior when the registry is used.