-
Notifications
You must be signed in to change notification settings - Fork 168
8384202: [lworld] C2: assert(offset == field->offset_in_bytes()) failed: offset mismatch #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TobiHartmann
wants to merge
3
commits into
openjdk:lworld
Choose a base branch
from
TobiHartmann:JDK-8384202
base: lworld
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestDeadInlineTypeFieldOffset.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /* | ||
| * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| package compiler.valhalla.inlinetypes; | ||
|
|
||
| import jdk.internal.vm.annotation.LooselyConsistentValue; | ||
| import jdk.internal.vm.annotation.NullRestricted; | ||
|
|
||
| /* | ||
| * @test | ||
| * @summary Test loads from a dead InlineTypeNode with top field values. | ||
| * @bug 8384202 | ||
| * @requires vm.compiler2.enabled | ||
| * @requires (vm.opt.PreloadClasses == null | vm.opt.PreloadClasses == "true") | ||
| * @enablePreview | ||
| * @modules java.base/jdk.internal.vm.annotation | ||
| * @run main ${test.main.class} | ||
| * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+IgnoreUnrecognizedVMOptions | ||
| * -XX:+StressIGVN -XX:StressSeed=8 -XX:+AlwaysIncrementalInline | ||
| * ${test.main.class} | ||
| */ | ||
| public value class TestDeadInlineTypeFieldOffset { | ||
| MyValue valueField1; | ||
| @NullRestricted | ||
| MyValue valueField2; | ||
|
|
||
| TestDeadInlineTypeFieldOffset(MyValue valueField1, MyValue valueField2) { | ||
| this.valueField1 = valueField1; | ||
| this.valueField2 = valueField2; | ||
| } | ||
|
|
||
| TestDeadInlineTypeFieldOffset test1() { | ||
| return new TestDeadInlineTypeFieldOffset(null, valueField2); | ||
| } | ||
|
|
||
| TestDeadInlineTypeFieldOffset test2() { | ||
| return new TestDeadInlineTypeFieldOffset(valueField1, null); | ||
| } | ||
|
|
||
| @LooselyConsistentValue | ||
| static value class NestedValue { | ||
| int x; | ||
| int y; | ||
|
|
||
| NestedValue(int x, int y) { | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
| } | ||
|
|
||
| @LooselyConsistentValue | ||
| static value class MyValue { | ||
| NestedValue v1; | ||
| @NullRestricted | ||
| NestedValue v2; | ||
|
|
||
| MyValue(NestedValue v1, NestedValue v2) { | ||
| this.v1 = v1; | ||
| this.v2 = v2; | ||
| } | ||
| } | ||
|
|
||
| static TestDeadInlineTypeFieldOffset test(TestDeadInlineTypeFieldOffset vt) { | ||
| vt = vt.test1(); | ||
| try { | ||
| vt = vt.test2(); | ||
| throw new RuntimeException(); | ||
| } catch (NullPointerException e) { | ||
| // Expected. | ||
| } | ||
| return vt; | ||
| } | ||
|
|
||
| public static void main(String[] args) { | ||
| MyValue val = new MyValue(null, new NestedValue(5, 6)); | ||
| TestDeadInlineTypeFieldOffset vt = new TestDeadInlineTypeFieldOffset(null, val); | ||
| for (int i = 0; i < 10_000; ++i) { | ||
| vt = test(vt); | ||
| } | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded is on purpose? It reproduces so rarely otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's on purpose to make it reliably reproduce the issue and the usual way of how we design these tests. I.e. one run with fixed seed and one without. As we discussed offline, there are several alternatives to this approach, including
RepeatCompilationetc. We decided on the current approach a while ago but we can surely revisit. It's out of scope of this PR though 🙂Testing also revealed that PreloadClasses is required to make sure that the
@NullRestrictedannotation is respected, so I added a corresponding@requires.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that means this test lacks a test that does not use a fixed seed?