Skip to content

8383809: [type-classes] Prototype UInt128#2420

Open
rgiulietti wants to merge 1 commit into
openjdk:type-classesfrom
rgiulietti:8383809
Open

8383809: [type-classes] Prototype UInt128#2420
rgiulietti wants to merge 1 commit into
openjdk:type-classesfrom
rgiulietti:8383809

Conversation

@rgiulietti
Copy link
Copy Markdown
Contributor

@rgiulietti rgiulietti commented May 11, 2026

Prototype a fully functional unsigned int128 type as a Valhalla value class.



Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8383809: [type-classes] Prototype UInt128 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2420/head:pull/2420
$ git checkout pull/2420

Update a local copy of the PR:
$ git checkout pull/2420
$ git pull https://git.openjdk.org/valhalla.git pull/2420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2420

View PR using the GUI difftool:
$ git pr show -t 2420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2420.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 11, 2026

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into type-classes will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 11, 2026

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8383809: [type-classes] Prototype UInt128

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the type-classes branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 11, 2026

Webrevs

@rgiulietti
Copy link
Copy Markdown
Contributor Author

Subject to change and discussion:

  • Use of factory methods rather than constructors.
  • Adding/changing/removing functionality (e.g., adding rotateLeft()).
  • Adding more general *Exact() methods that throw on overflow.
  • Use of typeclass mechanisms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant