8384068: [lworld] ValueClassPlugin misses some annotations

[xmas92]

There are few places which uses the fully qualified name for the AsValueClass annotation. As a result the plugging does not modify these classes when compiling, so they are still identity classes.

I propose improving the robustness of this plugin. We need to do this during parsing so we cannot actually check 100% that it will resolve to the correct annotation. However we can do a best effort, which handles same package, fully qualified, imported and rejects other annotations with the same class name.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8384068: [lworld] ValueClassPlugin misses some annotations (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2405/head:pull/2405
$ git checkout pull/2405

Update a local copy of the PR:
$ git checkout pull/2405
$ git pull https://git.openjdk.org/valhalla.git pull/2405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2405

View PR using the GUI difftool:
$ git pr show -t 2405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2405.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (9b4a1cd8)