8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg#2404
8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg#2404xmas92 wants to merge 1 commit into
Conversation
|
👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into |
|
@xmas92 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
TestDeadAllocationRemoval.java is missing the
@testannotation in its comment and is ignored by jtreg. The test also refers to a nonexistent class, why is probably an uncaught typo caused by the test not actually being ran.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2404/head:pull/2404$ git checkout pull/2404Update a local copy of the PR:
$ git checkout pull/2404$ git pull https://git.openjdk.org/valhalla.git pull/2404/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2404View PR using the GUI difftool:
$ git pr show -t 2404Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2404.diff
Using Webrev
Link to Webrev Comment