8384061: [lworld] VM_PrintClassLayout uses the wrong VMOp_Type

[xmas92]

VM_PrintClassLayout uses the wrong VMOp_Type.

Probably a copy paste error. Uses VMOp_PrintClassHierarchy instead of VMOp_ClassPrintLayout.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8384061: [lworld] VM_PrintClassLayout uses the wrong VMOp_Type (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Committer) ⚠️ Review applies to 617c434d
• Joel Sikström (@jsikstro - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2401/head:pull/2401
$ git checkout pull/2401

Update a local copy of the PR:
$ git checkout pull/2401
$ git pull https://git.openjdk.org/valhalla.git pull/2401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2401

View PR using the GUI difftool:
$ git pr show -t 2401

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2401.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384061: [lworld] VM_PrintClassLayout uses the wrong VMOp_Type

Reviewed-by: stefank, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (3b24de1e)
• 01: Full - Incremental (617c434d)
• 00: Full (092b35c7)

[jsikstro]

Looks good.

[xmas92]

I think the reason it was called ClassPrintLayout is because it is used by VM.class_print_layout d/jcmd. However there is some discrepancy here in our internal symbol names. But as the VMOp_type name will be seen externally it should probably be consistent with the cmd.

I'll look at renaming VM_PrintClassLayout, PrintClassLayout and PrintClassLayoutDCmd to be consistent with VM.class_print_layout.

[jsikstro]

Pre-existing: The indentation here is inconsistent, but so is this file in general.

[jsikstro]

Looks good.