8381531: [lworld] Startup performance regression with Valhalla caused by Method::link_method#2357
Draft
matias9927 wants to merge 13 commits into
Draft
8381531: [lworld] Startup performance regression with Valhalla caused by Method::link_method#2357matias9927 wants to merge 13 commits into
matias9927 wants to merge 13 commits into
Conversation
|
👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
DanHeidinga
reviewed
Apr 22, 2026
| ResourceMark rm; | ||
| bool new_entry = false; | ||
|
|
||
| // Inherit adapter from super method as long as it is compatible with adapters from local interfaces |
Contributor
There was a problem hiding this comment.
Can we wrap this in a if (!method->is_static()) {...} block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
Method::link_method()has a notable impact on overhead and results in notable performance regressions from mainline. The source of this performance difference seems to be the aggressive calculation and recalculation of signature calling conventions for methods. This patch introduces the possibility for methods to inherit adapters from super methods so long as its calling conventions are compatible with the calling conventions introduced by local interfaces.This design reports a x-y% improvment.
Verified with tier 1-5 tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2357/head:pull/2357$ git checkout pull/2357Update a local copy of the PR:
$ git checkout pull/2357$ git pull https://git.openjdk.org/valhalla.git pull/2357/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2357View PR using the GUI difftool:
$ git pr show -t 2357Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2357.diff