Skip to content

Fix missing boat sprite icon in attacks panel #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camclark wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix missing boat sprite icon in attacks panel #4141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24ae58b
Fix missing boat sprite icon in attacks panel
camclark Jun 3, 2026
72e519c
Remove redundant comments
camclark Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/client/hud/layers/AttacksDisplay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
} from "../../Transport";
import { UIState } from "../../UIState";
import { renderTroops, translateText } from "../../Utils";
import { getColoredSprite } from "../SpriteLoader";
import { getColoredSprite, loadAllSprites } from "../SpriteLoader";
const soldierIcon = assetUrl("images/SoldierIcon.svg");
const swordIcon = assetUrl("images/SwordIcon.svg");

Expand All @@ -47,7 +47,11 @@ export class AttacksDisplay extends LitElement implements Controller {
return this;
}

init() {}
init() {
loadAllSprites().catch((err) =>
console.error("Failed to preload attack display sprites:", err),
);
}
Comment on lines +50 to +54
Copy link
Copy Markdown
Collaborator

@evanpelle evanpelle Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead we should move it to GameRenderer.initialize(), since multiple layers use sprites.


tick() {
this.active = true;
Expand Down
Loading