fix(search|a11y): avoid input focus

[abulte]

Depends datagouv/cdata#1096
Fix ecolabdata/ecospheres#1115

[streino]

OK as far as I can tell (not much). I'd rather rely on @narduin's review.

The base branch was changed.

[narduin]

So the page title doesn't change anymore when you do a search is that right?
We have a special title that's sent to be announced in the live region instead?

[abulte]

So the page title doesn't change anymore when you do a search is that right? We have a special title that's sent to be announced in the live region instead?

Before #1153, we had a live region announcement of the search results count (which you implemented ;-)). Since it was broken by the new component, it's reintroduced here. It's not a title, cf the debug logs in console:

[LiveRegion] Announcement [{"text":"Page Toutes les données pour \"xxtestxx\" | ecologie.data.gouv.fr"},{"text":"13 résultats"}]

[narduin]

Before #1153, we had a live region announcement of the search results count (which you implemented ;-)). Since it was broken by the new component, it's reintroduced here. It's not a title, cf the debug logs in console:

Yep I remember 😁
Although I thought the search results were also added to the page title, has it been too long for my memory already? 😨

[abulte]

Before #1153, we had a live region announcement of the search results count (which you implemented ;-)). Since it was broken by the new component, it's reintroduced here. It's not a title, cf the debug logs in console:

Yep I remember 😁 Although I thought the search results were also added to the page title, has it been too long for my memory already? 😨

I don't remember either 😬 Should they? Seems a bit redundant if live region is updated, no?

[narduin]

I think the title and the live region were both updated on route change but it should be tested with a screen reader to be sure.
If that's not the case anymore we might not need to update the live region here but could use the actual text "XX résultats" as a live region.

[abulte]

I think the title and the live region were both updated on route change but it should be tested with a screen reader to be sure. If that's not the case anymore we might not need to update the live region here but could use the actual text "XX résultats" as a live region.

"XX résultats" is now upstream, so this might be hard.

[narduin]

"XX résultats" is now upstream, so this might be hard.

It might be enough because it has a role="status" on it! Which is annouced when updated automatically.

<p
  class="fr-col-auto my-0"
  role="status"
  data-testid="search-result-count"
>
  {{ t("{count} résultats | {count} résultat | {count} résultats", searchResults.total) }}
</p>

When testing this branch with a screen reader, the "live title" is annouced twice and the results are also announced since role="status" is an implicit live region.

Page Jeux de données pour "occitqnie" | accessibilite.data.gouv.fr 2 résultats    
Page Jeux de données pour "occitqnie" | accessibilite.data.gouv.fr 2 résultats   
2 résultats

[abulte]

@narduin so I should remove results announcement feature from this PR?

[narduin]

@narduin so I should remove results announcement feature from this PR?

I believe so, yes.

[abulte]

/deploy ecospheres