Moving laravel framework to require-dev#113
Open
mevtho wants to merge 1 commit into
Open
Conversation
iBotPeaches
requested changes
Apr 4, 2025
Collaborator
iBotPeaches
left a comment
There was a problem hiding this comment.
I don't believe this is the right fix. Including full Laravel was probably a mistake, but I see 4 occurrences of Illuminate.
use Illuminate\Console\Command;
use Illuminate\Contracts\Support\DeferrableProvider;
use Illuminate\Support\ServiceProvider as BaseServiceProvider;
use Illuminate\Support\Facades\Facade;
So we could probably isolate down to Console, Contracts and Support.
Console could probably be dev, as its only used in the install command.
Collaborator
|
I took a look at this again. I ported over the splits and crashes were because all of these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to discussions
#40
#34
I had the a similar issue when trying to add the package to a laravel-zero application (conflict with Illuminate packages).
Moving to require-dev should allow the same development experience while not forcing a full install of the laravel framework when adding to a laravel-zero project.