Improve EOF error messages on schema validation#35
Open
ehennestad wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Improved the end-of-file validation messages in
openMINDS_validation/utils.pyby:}followed by a single newlineWhy
The previous EOF check could report misleading errors for some invalid file endings. For example, when validating a file with 2 newline characters at the end of the file, the error would state:
No newline at end of fileImpact
Schema validation failures caused by invalid file endings should now be easier to understand and fix.
Validation
openMINDS_validation/utils.pysuccessfully withast.parse