Add support for ADL 2.4 at-coded node id's#660
Conversation
* [WIP] ADL++ * [WIP] ADL++ --------- Co-authored-by: Jelte Zeilstra <jelte.zeilstra@nedap.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
============================================
+ Coverage 72.19% 72.26% +0.06%
- Complexity 7201 7222 +21
============================================
Files 680 680
Lines 23363 23389 +26
Branches 3783 3787 +4
============================================
+ Hits 16868 16902 +34
+ Misses 4756 4750 -6
+ Partials 1739 1737 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@joostholslag What is the purpose of this PR? It includes the changes from #659 which were merged 2 days ago. |
|
That pr was merged into a branch that this pr now merges into main. I assume more changes will have to be done to have a single pr for adl2.4 changes to Archie. |
|
Thank you for pointing this out. I missed that #659 was merged into a branch. Can't wait to land these changes into main branch. |
|
@MattijsK would you be willing to list the other required changes in the PR description? |
|
This file needs updating too https://github.com/openEHR/archie/blob/master/base/src/main/java/com/nedap/archie/definitions/AdlCodeDefinitions.java not sure it’s covered by the todo in the pr text. |
* Be able to set adlVersion in the configuration: * Add configuration to convert adl1.4 into adl2 at-coded * Remake example archetypes * Fix conversion of valueSets * remove dutch comments * requested changes * Change NodeIdUtil codes to String * Fix issues * Fix issue that new nodes are created in specialisations * Fix tests * Revert gitignore change * Update .gitignore * Extract code to check code system and update documentation * Update tests * Update ADL14ToADL2Test.java * Make tests better * extract code that removed unnecessary codes * add comment * Update ADL14ToADL2Test.java * Requested changes * Update code after merge * Fix test now that the order of terminology codes is normal again * Update ArchetypeTerm.java * Update ArchetypeTerm.java * Update TerminologyRelation.java * Update TerminologyRelation.java
Draft (to keep up to date on progresse)
[WIP] ADL++
[WIP] ADL++
ADL 2.4 support in Archie