Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
============================================
+ Coverage 70.28% 70.38% +0.10%
- Complexity 6314 6347 +33
============================================
Files 628 629 +1
Lines 21266 21350 +84
Branches 3411 3425 +14
============================================
+ Hits 14946 15028 +82
+ Misses 4713 4708 -5
- Partials 1607 1614 +7
Continue to review full report at Codecov.
|
Collaborator
Author
|
Needs some extra work for the classes in #346 - not doing it there because it will cause nasty conflicts |
J3173
reviewed
Oct 11, 2021
Comment on lines
+1
to
+3
| @javax.xml.bind.annotation.XmlSchema(namespace = "http://schemas.openehr.org/v1", /*xmlns = {@XmlNs(prefix = "", namespaceURI = "http://schemas.openehr.org/v1") | ||
|
|
||
| }*/ elementFormDefault = XmlNsForm.QUALIFIED, attributeFormDefault = javax.xml.bind.annotation.XmlNsForm.UNQUALIFIED) |
Collaborator
There was a problem hiding this comment.
There are some commented out things here, are they still needed?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #343 . Adds the http://schemas.openehr.org/v1 namespace to the JAXB-bindings.
note that this is a breaking change:
[name/value = '...']will have to be changed to `[openehr:name/openehr:value = '...']. The regular path lookup remains unchanged.The alternative:
might be better than this actually...