feat(kube-stack): add top-level resourceAttributes - #2393
Merged
jaronoff97 merged 5 commits intoSep 9, 2026
Conversation
Contributor
Author
Add example of global resourceAttributes
Resolve conflict in templates/collector.yaml: adopt upstream's new `opentelemetry-kube-stack.mergeCollector` helper (from the `inheritDefaultCRConfig` feature, open-telemetry#2394) while preserving the `resourceAttributes` entry added to the `$merged` dict on this branch. Bump chart version to 0.20.8 since upstream already tagged 0.20.7 with only the inheritDefaultCRConfig feature, and this merge adds `resourceAttributes` on top. Regenerate examples accordingly. Assisted-by: Claude Opus 4.7 (1M context)
jaronoff97
approved these changes
Sep 9, 2026
Contributor
|
thank you for your contribution! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a top-level
resourceAttributes: {}map to theopentelemetry-kube-stackchart, providing a single place to set default resource attributes (e.g.
deployment.environment.name,k8s.cluster.name) that apply to both the collectors thischart deploys and the
InstrumentationCR it manages. Previously, users hadto duplicate the same attributes in two unrelated places: manually as a
resourceprocessor in each collector's config, and again ininstrumentation.resource.resourceAttributes.Wiring:
resource/globalprocessor withaction: upsertand appended to every existing pipeline (traces, metrics,logs).
upsertsemantics ensure explicit values here take precedence overanything auto-detected earlier in the pipeline (e.g. by
resourcedetection).instrumentation.resource.resourceAttributes; any per-key value already setin the instrumentation section wins on conflict, preserving existing
behavior for users who already configure it there.
collectors.<name>.resourceAttributesis alsoaccepted and overlays the top-level map (per-collector keys win) so a
specific collector pool can extend or override the defaults.
Link to tracking issue
Fixes #2338
Authorship