fix(opentelemetry-demo): wait for flagd before starting shipping - #2384
Open
dpacheconr wants to merge 1 commit into
Open
fix(opentelemetry-demo): wait for flagd before starting shipping#2384dpacheconr wants to merge 1 commit into
dpacheconr wants to merge 1 commit into
Conversation
shipping crash-loops on a fresh install or rollout because there is no ordering guarantee between the shipping and flagd deployments. Add a wait-for-flagd initContainer, matching the existing wait-for-kafka / wait-for-valkey-cart pattern already used by other components in this chart, so shipping blocks until flagd:8013 is reachable instead of crashing. Assisted-by: Claude Sonnet 5
dpacheconr
added a commit
to dpacheconr/opentelemetry-demo
that referenced
this pull request
Sep 3, 2026
Comment the wait-for-flagd initContainer as a workaround, pointing at open-telemetry/opentelemetry-helm-charts#2384 so it's removed once the upstream chart handles this itself. Assisted-by: Claude Sonnet 5
dpacheconr
added a commit
to newrelic/opentelemetry-demo
that referenced
this pull request
Sep 3, 2026
* fix(newrelic/k8s): wait for flagd before starting shipping shipping crash-loops on install/rollout since there's no ordering guarantee between the shipping and flagd deployments. Add a wait-for-flagd initContainer (busybox nc, same pattern as the chart's existing wait-for-kafka/wait-for-valkey-cart containers) so shipping blocks until flagd:8013 is reachable instead of crashing. Tested locally in minikube: scaled flagd to 0 replicas, restarted shipping — it now sits at Init:0/1 with 0 restarts until flagd comes back, then starts cleanly. Assisted-by: Claude Sonnet 5 * docs(newrelic/k8s): note upstream fix for shipping/flagd wait Comment the wait-for-flagd initContainer as a workaround, pointing at open-telemetry/opentelemetry-helm-charts#2384 so it's removed once the upstream chart handles this itself. Assisted-by: Claude Sonnet 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
shippingcrash-loops on a fresh install or rollout because there is noordering guarantee between the
shippingandflagddeployments — ifshippingstarts beforeflagd's port is up, it panics and restartsuntil
flagdhappens to be ready.open-telemetry/opentelemetry-demo#3875 attempted to fix this in
application code (falling back to
open_feature::NoOpProviderwhenFlagdProvider::newfails at startup), but that approach was pushed backon in review. This PR fixes it at the chart level instead: a
wait-for-flagdinitContainer onshipping, using the exact samepattern the chart already uses for
cart(wait-for-valkey-cart) andother components (
wait-for-kafka) — no application code changes needed.Bumped the chart to 0.41.1 (patch, additive/non-breaking) and
regenerated the example manifests via
make generate-examples CHARTS=opentelemetry-demo.Link to tracking issue
Related to open-telemetry/opentelemetry-demo#3845, alternative approach to open-telemetry/opentelemetry-demo#3875
Authorship