fix(schema): remove required apiVersion value - #2380
Conversation
Signed-off-by: Baptiste ROUX <arte.but.posix@gmail.com>
Signed-off-by: Baptiste ROUX <arte.but.posix@gmail.com>
|
why we need to remove |
It's not removed it's still here. I removed it from the required fields because the field is an override and if we're fine with using the default value because of this required field we still have to provide it. |
|
@baprx it would be dangerous to remove What issue are you running into with it being required? |
|
@TylerHelmuth the issue is not blocking on my side, just a bit annoying since the schema validation flags the whole file as errored in my IDE because of this field not being explicitly configured but I can ignore it you don't think merging this is a good idea. I thought this would be an acceptable change since explicitly setting it to null would likely not happen or lead to an error anyway (either erroring because of the schema or because missing to create the deployment/daemonset/statefulset objects). |
|
We like to rely on the json schema whenever possible for validation so keep apiVersion required is necessary. |
Description
I've just updated the values schema, I wasn't sure if a Chart bump was required, I can revert it if you prefer.
.Values.apiVersionis set to a default value so the JSON schema should not require it to be set in user configurations.Authorship