[chore]: update all CI to helm 4+ - #2237
Merged
TylerHelmuth merged 4 commits intoMay 28, 2026
Merged
Conversation
jaronoff97
approved these changes
May 28, 2026
TylerHelmuth
marked this pull request as draft
May 28, 2026 21:05
Helm 4 changed manifest rendering (it preserves trailing whitespace before document separators and at EOF that Helm 3 stripped), so examples regenerated with Helm 4 failed the Helm 3 check-examples job in CI. - Pin every CI test matrix to Helm v4.0.3 only, and bump the release and update-chart-app-version workflows to v4.0.3. - Extend the generate-examples/check-examples normalization to strip trailing whitespace before "---" separators and at EOF, keeping rendered output stable. - Require Helm 4.0+ in CONTRIBUTING. Assisted-by: Claude Opus 4.8
- Document Helm 4.0+ as the prerequisite in every chart README. - Pin all CI workflows to the latest 4.0.x patch (v4.0.5). - Bump each chart's patch version and regenerate all examples. Assisted-by: Claude Opus 4.8
TylerHelmuth
changed the title
…porters
The otlp/jaeger and otlphttp/prometheus exporters configured
sending_queue.batch as a null value. Helm 4.2 prunes the null key and
renders `sending_queue: {}`, while Helm 4.0.x renders `batch: null`,
which made example rendering depend on the contributor's Helm version.
Set `batch: {}` explicitly so the config renders identically across Helm
4.x versions. The collector resolves `batch: null` and `batch: {}` to the
same value (sending_queue.batch defaults to configoptional.Default, so
both produce Some(default BatchConfig)), so this is behavior-preserving.
Assisted-by: Claude Opus 4.8
TylerHelmuth
marked this pull request as ready for review
May 28, 2026 21:41
TylerHelmuth
requested review from
Allex1,
atoulme,
dmitryax,
julianocosta89,
povilasv and
puckpuck
as code owners
May 28, 2026 21:41
TylerHelmuth
commented
May 28, 2026
| insecure: true | ||
| sending_queue: | ||
| batch: | ||
| batch: {} |
Member
Author
There was a problem hiding this comment.
The collector treats this the same and setting this prevents 4.0.x and 4.2.x from rendering differently
jaronoff97
approved these changes
May 28, 2026
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm 3 and helm 4 render different, and it is causing problems in CI and when users render examples. This updates all CI to helm 4