Skip to content

Make sure that there is single SignedProperties element #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metsma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure that there is single SignedProperties element #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/SignatureXAdES_B.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ void SignatureXAdES_B::validate(const string &policy) const

map<string,string> signatureref;
string_view signedPropertiesId = sp["Id"];
bool signedInfoFound = false;
int signedInfoFound = 0;
for(auto ref = signature/"SignedInfo"/"Reference"; ref; ref++)
{
auto uri = ref["URI"];
Expand All @@ -498,7 +498,7 @@ void SignatureXAdES_B::validate(const string &policy) const
}

if(uri.front() == '#' && uri.substr(1) == signedPropertiesId && ref["Type"] == REF_TYPE)
signedInfoFound = true;
++signedInfoFound;
else if(!sdop)
continue; // DataObjectProperties is missing, no need to match later MediaTypes
else if(ref["Id"].empty())
Expand All @@ -511,8 +511,8 @@ void SignatureXAdES_B::validate(const string &policy) const
signatureref.emplace(uriPath, mimeinfo[string("#").append(ref["Id"])]);
}
}
if(!signedInfoFound)
EXCEPTION_ADD(exception, "SignedProperties not found");
if(signedInfoFound != 1)
EXCEPTION_ADD(exception, "Exactly one SignedProperties Reference required, found %d", signedInfoFound);

// Match DataObjectFormat element MediaTypes with Manifest
if(!signatureref.empty())
Expand Down
Loading