Adapt to latest changes in llm microservice famliy#696
Merged
Conversation
1 task
Collaborator
Author
|
PR #697 will fix the doc CI issue |
yongfengdu
approved these changes
Jan 14, 2025
yongfengdu
force-pushed
the
llm-uservice
branch
from
ce497c1 to
b76cc25
Compare
eero-t
reviewed
Jan 14, 2025
eero-t
left a comment
eero-t
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine. I have few questions and doc suggestions though.
lianhao
force-pushed
the
llm-uservice
branch
2 times, most recently
from
567cc14 to
aa6b8f6
Compare
Ruoyu-y
reviewed
Jan 15, 2025
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
eero-t
reviewed
Jan 15, 2025
Comment on lines
+87
to
+89
| | TEXTGEN_BACKEND | string | `"tgi"` | backend inference engine, only valid for llm-textgen image, one of "TGI", "vLLM" | | ||
| | DOCSUM_BACKEND | string | `"tgi"` | backend inference engine, only valid for llm-docsum image, one of "TGI", "vLLM" | | ||
| | FAQGEN_BACKEND | string | `"tgi"` | backend inference engine, only valid for llm-faqgen image, one of "TGi", "vLLM" | |
Collaborator
There was a problem hiding this comment.
ConfigMap template does case-sensitive comparison, so the default values need to be updated too: tgi -> TGI.
Collaborator
Author
There was a problem hiding this comment.
since it's already merged, I'll do that in another pending PR.
Collaborator
|
Noticed couple of missed changes which could be also fixed in another PR: (First one is fixed also in in #649.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapt to latest changes in llm microservice famliy.
Issues
Fixes #691
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.