This repository was archived by the owner on Jan 16, 2026. It is now read-only.
docs(node): update actor design documentation#3195
Open
Himess wants to merge 4 commits into
Open
Conversation
Update documentation to match current codebase after actor system refactoring: - Update NodeActor trait example to use simplified trait signature (Error + StartData types instead of InboundData/OutboundData/State) - Replace outdated RollupNodeService trait example with RollupNodeBuilder usage - Update design/intro.mdx to reference RollupNode and RollupNodeBuilder instead of the removed RollupNodeService trait - Fix broken GitHub links to point to current file locations - Update terminology (remove "subclassing" which doesn't apply to Rust) Closes op-rs#3137
Himess
requested review from
BioMark3r,
einar-oplabs,
emhane,
op-will and
theochap
as code owners
…ntation - Update NodeActor trait in engine.mdx to use simplified signature (Error, StartData) - Remove outdated RollupNodeService trait reference in sequencer.mdx - Replace InboundData/OutboundData/Builder with current StartData pattern
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been automatically marked as stale because it has been inactive for 3 weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates outdated docs after actor system refactoring. Fixed
NodeActortrait examples, removedRollupNodeServicereferences, and fixed a broken GitHub link.Closes #3137