ci: update deprecated actions and test claimed Python 3.9 support - #547
Open
ThVerg wants to merge 2 commits into
Open
ci: update deprecated actions and test claimed Python 3.9 support#547ThVerg wants to merge 2 commits into
ThVerg wants to merge 2 commits into
Conversation
actions/checkout@v2 and actions/setup-python@v1 run on Node.js versions that GitHub has deprecated. Bump all checkout/setup-python steps to their current majors (v4/v5). pyproject.toml declares requires-python >=3.9 (and carries the importlib_metadata backport for it), but CI only tested 3.10-3.14. Add 3.9 to the matrix so the claimed support is actually exercised.
The gui parametrization uses a PEP 604 annotation (bool | None) that is evaluated at function definition time, which breaks test collection on 3.9. Add 'from __future__ import annotations' so the annotation stays a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI health fixes:
actions/checkout@v2andactions/setup-python@v1, which run on Node.js versions GitHub has deprecated on current runners (the Format job was on v3). All checkout/setup-python steps are bumped to the current majors (v4/v5).pyproject.tomldeclaresrequires-python = ">=3.9"and carries theimportlib_metadatabackport dependency specifically for 3.9, but the CI matrix only tested 3.10–3.14. This adds 3.9 to the matrix so the claimed lower bound is actually exercised. (If 3.9 is no longer worth supporting, the alternative is bumpingrequires-pythonto>=3.10and dropping the backport shim — happy to rework the PR that way instead.)Deliberately not included: bumping the black pre-commit pin (22.3.0). Every newer black release reformats existing files (black 24.x touches 8 files, 26.x touches 45), so that's better done as a standalone reformat commit to keep other PRs conflict-free.