Rename kA to UA and zeta to zeta_d4#989
Open
fwitte wants to merge 9 commits into
Open
Conversation
Member
Author
|
Everything changed in src tests still all pass (except exerpy related ones), so green light here. |
Member
Author
|
Last missing piece is a unit test that verifies the conversion of the parameters. Right now the tests implicitly do because all the test still use the old zeta/kA specifications. But this will also be changed, so there must be a test that checks if specification of a deprecated parameter which will be renamed will correctly specify the renamed parameter and its result will correctly be passed back to the deprecated parameter. This is to be checked for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #979
Resolves #976
This PR will also add a new consistent parameter
lmtdfor all heat exchanger types which is equal toQ/UAthe citable contributor list