Skip to content

Fixing an issue with the function Xml_print.compose_decl. - #348

Closed
Mbodin wants to merge 1 commit into
ocsigen:masterfrom
Mbodin:master
Closed

Fixing an issue with the function Xml_print.compose_decl.#348
Mbodin wants to merge 1 commit into
ocsigen:masterfrom
Mbodin:master

Conversation

@Mbodin

@Mbodin Mbodin commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Currently the function Xml_print.compose_decl outputs a literal \n at the end of the first line, instead of a newline character. This makes the generated files invalid.

I also fixed some typos on the way.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in Xml_print.compose_decl where a literal \n string was being output instead of an actual newline character, which would make generated XML files invalid. The PR also includes several minor typo corrections in comments across the codebase.

Key changes:

  • Fixed compose_decl to use character literal '\n' instead of escape sequence in quoted string
  • Corrected grammar from "have" to "has" in documentation comments
  • Fixed missing space in function call formatting

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/xml_print.ml Fixed literal \n bug by using %c format specifier with '\n' character
lib/svg_sigs.mli Grammar correction in unary element comment (have → has)
lib/html_sigs.mli Grammar correction in unary element comment (have → has)
lib/svg_f.ml Added missing space between function name and argument

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/svg_sigs.mli
Comment thread lib/html_sigs.mli
@balat

balat commented Aug 27, 2026

Copy link
Copy Markdown
Member

Thanks for this, and sorry it waited so long. Picked up in #374, rebased on
master with tests that fail without the fix. I also extended the documentation
comment fix: it read "an element that have exactly one children", so "children"
became "child" too.

Keeping this open until #374 lands, then it closes with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants