Fixing an issue with the function Xml_print.compose_decl. - #348
Conversation
Also fixing some typos.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in Xml_print.compose_decl where a literal \n string was being output instead of an actual newline character, which would make generated XML files invalid. The PR also includes several minor typo corrections in comments across the codebase.
Key changes:
- Fixed
compose_declto use character literal'\n'instead of escape sequence in quoted string - Corrected grammar from "have" to "has" in documentation comments
- Fixed missing space in function call formatting
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/xml_print.ml | Fixed literal \n bug by using %c format specifier with '\n' character |
| lib/svg_sigs.mli | Grammar correction in unary element comment (have → has) |
| lib/html_sigs.mli | Grammar correction in unary element comment (have → has) |
| lib/svg_f.ml | Added missing space between function name and argument |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for this, and sorry it waited so long. Picked up in #374, rebased on Keeping this open until #374 lands, then it closes with it. |
Currently the function
Xml_print.compose_decloutputs a literal\nat the end of the first line, instead of a newline character. This makes the generated files invalid.I also fixed some typos on the way.