Conversation
there are now PPX attributes in many places, so (for example) what was a pair (pattern * expression) is now a triple (pattern * expression * attributes). Typically the attributes are empty in generated code. Since this is a spot that can have a meta-variable in quotations, we have to wrap the empty-list in a "vala". But again, this is pretty much a boilerplate value. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch camlp5-8.00-patches # Changes to be committed: # modified: pa_ulex.ml # # Untracked files: # _build/ #
# Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch camlp5-8.00-patches # Changes to be committed: # modified: opam # # Untracked files: # _build/ #
Why are you asking me? I have no write access to ocaml/opam-repository. |
|
Also, please rebase the branch on top of |
|
Done (I have rebased on top of your camlp5 branch). At the end, if you squash, there is only a very minor cleanup of the opam file left. About the PR to opam-repository: sorry, I made confusion with the multiple PRs I have opened. |
|
@sacerdot, if @whitequark and you are both agreeable, I can give you commit access to this repository as the new maintainer. |
4 participants
minor changes to META and opam file
This is the version released as 1.3 in opam for ulex-camlp5. The opam package points to the .tar.gz release of my fork.
If you want to sanitize the opam package releasing yourself this branch to be used for the ulex-camlp5, please go ahead.
Otherwise, or if you need more time to think about what to do, could you please in the meantime merge the ocaml/opam-repository#23229 PR that just allows compilation for 4.14.1?
Thanks a lot!