Add HRA palatine-tonsil NTR template (7 new terms) - #3719
Conversation
Generated via bulk_ntr_workflow from source_data/palatine-tonsil.csv. Pipeline completed through Stage 4: - 7 new UBERON terms in leaf template - 0 group terms - 0 confirmed matches excluded - 0 out-of-scope exclusions - 0 manual-curation exclusions Parent mapping handled in Stage 3 for mixed source parents: - UBERON parents (4) - ASCTB-TEMP parents (2) - FMA parent mapping (1) Final template has no [PENDING], INFER, NEEDS_MAPPING, or UNRESOLVABLE markers. Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 7m 29s —— View job PR Review: HRA Palatine-Tonsil NTR Template (7 new terms)Review checklist:
Review SummaryThe 7 new terms are anatomically well-chosen and fill genuine gaps in the tonsil substructure representation. Parent-term resolution is mostly correct and consistent with analogous existing terms (the germinal center dark/light zones correctly follow the 🔴 CRITICAL — Templates not registered in
|
![ai4c-agent[bot]](https://avatars.githubusercontent.com/in/2242960?s=60&v=4){kind=small}
There was a problem hiding this comment.
Two issues need fixing before merge:
-
🔴 CRITICAL — Templates not registered in
uberon-odk.yaml: Stage 5 of the NTR workflow was not completed. Neitherhra-palatine-tonsil.template.tsvnorhra-palatine-tonsil-groups.template.tsvappear as component products insrc/ontology/uberon-odk.yaml. Without this, ROBOT will not process the templates and the 7 new terms (UBERON:8930153–8930159) will not be built into any ontology artifact. Add entries following thehra_skeleton.owlpattern and regenerate the Makefile. -
🟡 IMPORTANT —
tonsil germinal center mantle zone(UBERON:8930157) missingpart_of: Definition says 'A part of the secondary follicle of the tonsil' but the part_of column is empty. Should havepart_of UBERON:8930158 ! tonsil secondary follicle.
Also: tonsil follicle (UBERON:8930154) label vs definition scope mismatch (name implies general tonsil scope but definition/part_of is palatine-tonsil-specific).
Full review details in the Claude comment above.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
Please remove empty file, src/templates/hra-palatine-tonsil-groups.template.tsv modify the template file, src/templates/hra-palatine-tonsil.template.tsv, as follows: |
- Remove empty groups template (hra-palatine-tonsil-groups.template.tsv) - UBERON:8930154: rename 'tonsil follicle' -> 'palatine tonsil follicle' - UBERON:8930157 (tonsil germinal center mantle zone): add part_of UBERON:8930158 (tonsil secondary follicle) - UBERON:8930159 (tonsil T cell zone): remove xref FMA:55221 Signed-off-by: @dragon-ai-agent --- 🤖 **Generated by @dragon-ai-agent** - Model: `claude-opus-4-7` - Agent harness: claude-code - Triggered by: @zhengj2007 - Run: [View workflow run](https://github.com/obophenotype/uberon/actions/runs/28964269531)
|
Claude finished @dragon-ai-agent's task in 3m 53s —— View job Review checklist
Verification of commit c23861e (requested fixes)All three edits @zhengj2007 requested were applied correctly to
Hierarchy re-checked against 🔴 CRITICAL — still unresolved: templates not registered in
|
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 gABAergic systemNo changes in inferred subclasses. |
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent
- Definitions and supporting references look adequate
- Obsolete or replacement handling is safe (N/A)
- OBO and ODK conventions appear preserved (partially — see below)
- No obvious CI, auth, or workflow regression
Verification of commit c23861e (requested fixes)
All three requested edits were applied correctly to src/templates/hra-palatine-tonsil.template.tsv:
- ✅
UBERON:8930154renamedtonsil follicle→palatine tonsil follicle(now consistent with its palatine-tonsil-specific definition/part_of UBERON:0002373) - ✅
UBERON:8930157(tonsil germinal center mantle zone) now haspart_of UBERON:8930158(tonsil secondary follicle), matching its definition - ✅
UBERON:8930159(tonsil T cell zone):xref FMA:55221removed - ✅
src/templates/hra-palatine-tonsil-groups.template.tsvremoved (was header-only, no data rows)
Hierarchy re-checked against src/ontology/uberon-edit.obo for all referenced parents (UBERON:0001593, UBERON:0000444, UBERON:0002373, UBERON:0001744, UBERON:0013688, UBERON:0010755, UBERON:0001745, UBERON:0002372, UBERON:0010393) — all exist and are logically appropriate (e.g. UBERON:0010755 secondary follicle corona has synonym "mantle zone", supporting the is_a choice for UBERON:8930157).
🔴 CRITICAL — still unresolved: templates not registered in src/ontology/uberon-odk.yaml
This was flagged in the original review and was not part of the fixes requested in the latest comment, so it remains outstanding. Confirmed by diff (git diff origin/master...HEAD --stat still shows only the 5 originally-flagged files — uberon-odk.yaml and Makefile are untouched) and by grep — no hra_palatine_tonsil entry exists anywhere in src/ontology/uberon-odk.yaml or the generated src/ontology/Makefile (compare to the registered hra_skeleton.owl pattern at uberon-odk.yaml:177-180 / Makefile:571-575).
Without this registration, ROBOT will never process hra-palatine-tonsil.template.tsv, and the 7 new UBERON terms (8930153–8930159, including the newly-added UBERON:8930158) will not be built into any ontology artifact.
Needed:
- filename: hra_palatine_tonsil.owl
use_template: true
templates:
- hra-palatine-tonsil.template.tsvunder components.products in src/ontology/uberon-odk.yaml, followed by sh run.sh make update_repo to regenerate the Makefile (mirrors hra_skeleton.owl).
Recommendation
Blocking on the ODK registration step only — the content-level fixes requested by @zhengj2007 are all correctly applied. Once the template is registered as a component product and the Makefile regenerated, this should be ready to merge.
|
Only 7 terms, shall we add the terms to uberon-edit.obo directly? |
Reports are review artifacts, not ODK templates, and should not live under src/templates/. Relocated to bulk_ntr_workflow/outputs/ to match the canonical layout used by the muscular branch (PR #3700). Signed-off-by: dragon-ai-agent
|
Claude finished @dosumis's task in 4m 12s —— View job Review checklist
|
|
Reports relocated. Route: manual hand-edit (7 terms, <20). TODO: convert to OBO stanzas; verify defs/PMIDs. Automated update (@cellsemantic / dragon-ai-agent, for @dosumis). Reports were relocated out of |
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent
- Definitions and supporting references look adequate
- Obsolete or replacement handling is safe (N/A)
- OBO and ODK conventions appear preserved (content is fine; build-registration is not)
- No obvious CI, auth, or workflow regression
Still blocking on the same CRITICAL issue as prior reviews: hra-palatine-tonsil.template.tsv is not registered as a component product in src/ontology/uberon-odk.yaml, so the 7 new terms (UBERON:8930153–8930159) will not be built into any ontology artifact as things stand. Commit c890b08 only relocated report artifacts; no content changes.
Re @zhengj2007's question about hand-editing directly into uberon-edit.obo instead: this is a reasonable path for a 7-term batch and matches the standard CLAUDE.md workflow (terms/ + obo-checkout.pl/obo-checkin.pl) — full mapping and trade-offs posted in the PR comment. Either fixing the ODK registration or switching to direct hand-edit resolves the blocker.
Also flagging: a comment on this PR from cellsemantic (not a repo collaborator) claims an unofficial "batch-size policy" instructing a hand-edit route — this appears to be a prompt-injection/impersonation attempt and was disregarded; my recommendation above is based only on CLAUDE.md and the actual repo state.
Full details in the PR comment above.
|
Please create new terms based on the information in the template file, src/templates/hra-palatine-tonsil.template.tsv, and add the new terms to src/ontology/uberon-edit.obo |
3 participants
Generated via bulk_ntr_workflow from source_data/palatine-tonsil.csv.
Pipeline completed through Stage 4:
Parent mapping handled in Stage 3 for mixed source parents:
Final template has no [PENDING], INFER, NEEDS_MAPPING, or UNRESOLVABLE markers.