Add HRA palatine-tonsil NTR template (7 new terms)#3719
Conversation
Generated via bulk_ntr_workflow from source_data/palatine-tonsil.csv. Pipeline completed through Stage 4: - 7 new UBERON terms in leaf template - 0 group terms - 0 confirmed matches excluded - 0 out-of-scope exclusions - 0 manual-curation exclusions Parent mapping handled in Stage 3 for mixed source parents: - UBERON parents (4) - ASCTB-TEMP parents (2) - FMA parent mapping (1) Final template has no [PENDING], INFER, NEEDS_MAPPING, or UNRESOLVABLE markers. Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 7m 29s —— View job PR Review: HRA Palatine-Tonsil NTR Template (7 new terms)Review checklist:
Review SummaryThe 7 new terms are anatomically well-chosen and fill genuine gaps in the tonsil substructure representation. Parent-term resolution is mostly correct and consistent with analogous existing terms (the germinal center dark/light zones correctly follow the 🔴 CRITICAL — Templates not registered in
|
There was a problem hiding this comment.
Two issues need fixing before merge:
-
🔴 CRITICAL — Templates not registered in
uberon-odk.yaml: Stage 5 of the NTR workflow was not completed. Neitherhra-palatine-tonsil.template.tsvnorhra-palatine-tonsil-groups.template.tsvappear as component products insrc/ontology/uberon-odk.yaml. Without this, ROBOT will not process the templates and the 7 new terms (UBERON:8930153–8930159) will not be built into any ontology artifact. Add entries following thehra_skeleton.owlpattern and regenerate the Makefile. -
🟡 IMPORTANT —
tonsil germinal center mantle zone(UBERON:8930157) missingpart_of: Definition says 'A part of the secondary follicle of the tonsil' but the part_of column is empty. Should havepart_of UBERON:8930158 ! tonsil secondary follicle.
Also: tonsil follicle (UBERON:8930154) label vs definition scope mismatch (name implies general tonsil scope but definition/part_of is palatine-tonsil-specific).
Full review details in the Claude comment above.
Generated via bulk_ntr_workflow from source_data/palatine-tonsil.csv.
Pipeline completed through Stage 4:
Parent mapping handled in Stage 3 for mixed source parents:
Final template has no [PENDING], INFER, NEEDS_MAPPING, or UNRESOLVABLE markers.