Everything

[obiwac]

This is the branch I maintain for external users to test out s2idle/S0ix on their machines.

The amdgpio suspend commit is not necessary for most machines, this is just because I have been told not servicing GPIO interrupts could be a blocker for S0i3 entry on some AMD machines.

[clausecker]

Works for me, had to apply this patch for the tree to build:

--- a/sys/dev/acpica/acpi.c
+++ b/sys/dev/acpica/acpi.c
@@ -4213,8 +4213,6 @@ static void
 acpi_system_eventhandler_wakeup(struct acpi_softc *const sc,
     const enum power_stype stype)
 {
-    struct acpi_softc *sc = (struct acpi_softc *)arg;
-
     ACPI_FUNCTION_TRACE_U32((char *)(uintptr_t)__func__, stype);
 
     sc->acpi_s2idle_wake = true;

[clausecker]

Weirdly though, my Thinkpad T16 only wakes up on lid switch, not on power button press. I would prefer for it to be the other way round. Had a history of the lid switch randomly triggering when the laptop is in my backpack on my previous one.

[obiwac]

Works for me, had to apply this patch for the tree to build:

--- a/sys/dev/acpica/acpi.c
+++ b/sys/dev/acpica/acpi.c
@@ -4213,8 +4213,6 @@ static void
 acpi_system_eventhandler_wakeup(struct acpi_softc *const sc,
     const enum power_stype stype)
 {
-    struct acpi_softc *sc = (struct acpi_softc *)arg;
-
     ACPI_FUNCTION_TRACE_U32((char *)(uintptr_t)__func__, stype);
 
     sc->acpi_s2idle_wake = true;

fixed, thanks :)