feat(cmd/network/status): Add network names to chain context#424
Merged
feat(cmd/network/status): Add network names to chain context#424
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
amela
force-pushed
the
amela/feat/chain-context
branch
from
4f7c836 to
6987bb8
Compare
matevz
approved these changes
Apr 10, 2025
| fmt.Println() | ||
|
|
||
| fmt.Printf("Chain context: %s", consensus.ChainContext) | ||
| fmt.Printf("Chain context: %s (%s)", npa.PrettyPrintNetwork(), consensus.ChainContext) |
Member
There was a problem hiding this comment.
Actually the idea of the issue was to lookup the network name based on the chain context here: https://github.com/oasisprotocol/oasis-sdk/blob/main/client-sdk/go/config/default.go
So if you're running a node locally and you name the network localhost, it should still print mainnet, if it's running on mainnet.
matevz
requested changes
Apr 10, 2025
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
Sorry, wrong button. Please properly resolve the comment ^^
amela
force-pushed
the
amela/feat/chain-context
branch
from
6987bb8 to
3e6f22e
Compare
matevz
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.