Channel event delete contact 2#5866
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 485 486 +1
Lines 25292 25309 +17
=========================================
+ Hits 25292 25309 +17 ☔ View full report in Codecov by Sentry. |
norkans7
changed the title
Member
|
Don't we need courier and mailroom changes before this? |
Author
|
Yes courier changes are nyaruka/courier#834 |
Author
|
Added the mailroom side too nyaruka/mailroom#455 |
norkans7
force-pushed
the
channel-event-delete-request-2
branch
from
358a982 to
c27203f
Compare
rowanseymour
requested changes
Feb 14, 2025
| ChannelEvent = apps.get_model("channels", "ChannelEvent") | ||
|
|
||
| num_updated = 0 | ||
| for event in ChannelEvent.objects.all(): |
Member
There was a problem hiding this comment.
this requires loading every single channel event into memory - look at other data migrations that load in batches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5849