Skip to content

fix: announce all content inside role="alert" #20056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mehm8128 wants to merge 5 commits into
base: master
Choose a base branch
from
+19 −5
Draft

fix: announce all content inside role="alert" #20056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62d6e75
fix: announce all content inside `role="alert"`
mehm8128 May 5, 2026
105e6ad
fix: pass proper child name and role to braille.handler.message
mehm8128 May 5, 2026
67d860f
fix: announce some role text
mehm8128 May 11, 2026
4e09548
fix: guard child.parent and remove the change of braille properties
mehm8128 May 15, 2026
cf78162
Pre-commit auto-fix
pre-commit-ci[bot] May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
View file
Open in desktop
Comment thread
seanbudd marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ We currently have the following templates:
* Please note that these are reported differently, for more information refer to our [disclosure policy/procedure](https://github.com/nvaccess/nvda/blob/master/security.md)
* Issues with materials handled by translators should be reported to the [NVDA Translators list](https://groups.io/g/nvda-translations).
These include:
* NVDA interface text that is incorrect in languages other than English
* Contents of the User Guide and Changes documents that are incorrect in languages other than English
* NVDA interface text that is incorrect in languages other than English
* Contents of the User Guide and Changes documents that are incorrect in languages other than English
* Input gestures, punctuation/symbol pronunciations, and character descriptions in languages other than English

These templates are fillable forms that guide you through the process of providing the necessary information for your issue.
Expand Down
4 changes: 2 additions & 2 deletions projectDocs/issues/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Do not report security concerns via GitHub issues, instead follow our [security
Issues with materials handled by translators should be reported to the [NVDA Translators list](https://groups.io/g/nvda-translations).
These include:

* NVDA interface text that is incorrect in languages other than English
* Contents of the User Guide and Changes documents that are incorrect in languages other than English
* NVDA interface text that is incorrect in languages other than English
* Contents of the User Guide and Changes documents that are incorrect in languages other than English
* Input gestures, punctuation/symbol pronunciations, and character descriptions in languages other than English

If you are reporting an issue with an application or website, please consider reporting the issue to the [authors of the application/website](./thirdPartyReporting.md) first.
Expand Down
15 changes: 14 additions & 1 deletion source/NVDAObjects/IAccessible/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,7 +2036,20 @@ def event_alert(self) -> None:
speech.speakObject(self, reason=controlTypes.OutputReason.FOCUS, priority=speech.Spri.NOW)
braille.handler.message(braille.getPropertiesBraille(name=self.name, role=self.role))
for child in self.recursiveDescendants:
if controlTypes.State.FOCUSABLE in child.states:
Comment thread
seanbudd marked this conversation as resolved.
if (
controlTypes.State.FOCUSABLE in child.states
or child.role
in (
controlTypes.Role.HEADING,
controlTypes.Role.LIST,
controlTypes.Role.LISTITEM,
)
or (
child.role == controlTypes.Role.STATICTEXT
and child.parent is not None
and child.parent.role == controlTypes.Role.PARAGRAPH
)
):
speech.speakObject(child, reason=controlTypes.OutputReason.FOCUS, priority=speech.Spri.NOW)
braille.handler.message(braille.getPropertiesBraille(name=self.name, role=self.role))

Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ It currently includes Screen Curtain's settings (previously in the "Vision" cate
* In the Input Gestures dialog, gestures including an operator while Num Lock is on will now be correctly displayed. (#19214, @CyrilleB79)
* In Chromium browsers, if a document contains links with a malformed URL, reading the document will be possible again. (#19125, @nvdaes)
* NVDA no longer plays a sound for spelling errors while typing if speech mode is set to on-demand or off. (#19323, @CyrilleB79)
* NVDA now announces heading, paragraph, list, and list item children inside `role="alert"` elements. (#14990, @mehm8128)

### Changes for Developers

Expand Down
Loading