Skip to content

Fixed Issues #55 and #56#58

Merged
yulmwu merged 2 commits into
mainfrom
feat/fixed-55-56
May 23, 2026
Merged

Fixed Issues #55 and #56#58
yulmwu merged 2 commits into
mainfrom
feat/fixed-55-56

Conversation

@yulmwu
Copy link
Copy Markdown
Member

@yulmwu yulmwu commented May 23, 2026

Title: Fixed Issues #55 and #56

For more details, please refer to the issues below.

Since this codebase is aligned with nullforu/wargame, the changes are also almost identical to commit nullforu/wargame@125e4c9.

However, since the frontend code exists separately in smctfe, the frontend changes were updated independently.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/service/user_service.go 63.63% 3 Missing and 1 partial ⚠️
internal/repo/user_repo.go 80.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Comment thread internal/bootstrap/testenv_test.go
@yulmwu yulmwu added the fixed label May 23, 2026
@yulmwu
Copy link
Copy Markdown
Member Author

yulmwu commented May 23, 2026

Since this is close to a mirror of the wargame codebase, I will not request LLM-based code review for this change.

@yulmwu yulmwu merged commit f7700fa into main May 23, 2026
2 checks passed
@yulmwu yulmwu deleted the feat/fixed-55-56 branch May 23, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant