Skip to content

Only allow a single instance of program to be run at a time#2923

Merged
manyoso merged 8 commits into
mainfrom
singleton_instance
Aug 30, 2024
Merged

Only allow a single instance of program to be run at a time#2923
manyoso merged 8 commits into
mainfrom
singleton_instance

Conversation

@manyoso

@manyoso manyoso commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Adds a new submodule of https://github.com/nomic-ai/SingleApplication which allows us to launch a single instance and guarantee further instances cannot be launched.

This is strictly a fork of the original, but we have a patch up for review here: itay-grudev/SingleApplication#197

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso marked this pull request as draft August 29, 2024 17:04
@manyoso manyoso requested a review from cebtenzzre August 29, 2024 17:07
@manyoso

manyoso commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator Author

@cebtenzzre should we try and raise the window using this workaround for windows? https://github.com/itay-grudev/SingleApplication/blob/master/Windows.md

@cebtenzzre

Copy link
Copy Markdown
Member

should we try and raise the window using this workaround for windows?

Yes, we should do those things as without it the user will get unexpected results.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso marked this pull request as ready for review August 30, 2024 15:14
@manyoso

manyoso commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator Author

This has been tested and works on all three major operating systems we support.

@manyoso manyoso changed the title Add new submodule and switch to singleton application by default. Only allow a single instance of program to be run at a time Aug 30, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
@manyoso manyoso merged commit 2f02cd4 into main Aug 30, 2024
@cebtenzzre cebtenzzre deleted the singleton_instance branch February 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants