Skip to content

button component #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
X905 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

button component #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63c4f9
button component
X905 Sep 22, 2020
742b6e6
includes a button that needs improvement
X905 Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions components/Button/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
export function Button(props){
const {className = '', ...restProps} = props;
return(
<button className={`bg-yellow text-black font-black text-xl px-6 py-5 hover:shadow-yellow ${className} `} {...restProps}>
Copy link
Copy Markdown
Member

@D3Portillo D3Portillo Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es sugerible no hacer un spread de las props restProps en el componente, en cambio sería mejor si las propiedades que este recibirá están detalladas con .propTypes, por ejemplo sabes que el botón tendrá un evento click, y en react la prop para los componentes para triggear el click es onClick

</button>

)
}


export function ButtonGray(props){
const {className = '', ...restProps} = props;
return(

<Button className={`bg-grey hover:shadow-grey ${className}`} {...restProps}>
</Button>
)
}
Copy link
Copy Markdown
Member

@D3Portillo D3Portillo Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semanticamente se entiende que este es un botón en gris, a diferencia de Button , que da entender que es solamente un botón, cuando la idea es tener 2 "sabores" del botón


Copy link
Copy Markdown
Member

@D3Portillo D3Portillo Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @X905 , sugiero mantener una consistencia en el nombraniento de los componentes, por ejemplo el CamelCase en las funciones sirve para identificar que son un Componente, y para el ambito de React que podes usar hooks y lo demás de la libreria,

Por ello es sugerible que para el caso de estos componentes, cada componente cómo Button y ButtonGray estén en un archivo nombrados de la misma mánera