Skip to content

Code Climate based fixes #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noahd1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code Climate based fixes #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f658d50
Remove unused variable per Code Climate
noahd1 Oct 19, 2015
3fe7d39
Ignore warnings about unused block args
noahd1 Oct 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .codeclimate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
engines:
rubocop:
enabled: true
fixme:
enabled: true
checks:
Rubocop/Lint/UnusedBlockArgument:
enabled: false
ratings:
paths:
- "**.rb"
Expand Down
4 changes: 2 additions & 2 deletions lib/oink/rails/memory_usage_logger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ def log_memory_usage
begin
memory_usage = Instrumentation::MemorySnapshot.memory
logger.info("Memory usage: #{memory_usage} | PID: #{$$}")
rescue Oink::Instrumentation::MemoryDataUnavailableError => e
rescue Oink::Instrumentation::MemoryDataUnavailableError
logger.error("Oink unable to retrieve memory on this system. See Oink::MemorySnapshot in source.")
end
end
end
end
end
end