Update to 36.0.1 (android-16.0.0_r4)

[luk1337]

Since it seems like Google has no plans to release new platform-tools tag, let's update to 36.0.1 released as part of AOSP 16 QPR2.

[Biswa96]

I'd like to wait for the maintainers and distro packages opinion about this update. I created an issue about releases code for newer platform tools in google tracker but got no reply.

[meator]

Just curious: How do you manage all the patches? There's quite a number of them in nmeum/android-tools. Does the update procedure look something like this?

• remove patches which are already part of the newer release
• if a patch no longer applies and the code hasn't changed much, make the minimum ammount of changes to the patch to make it apply
• if a patch no longer applies and the code has changed, assess whether the patch is still needed; if it is, rework it
• if there are compilation issues in the CI test matrix (or some other test environments), add patches to fix these

Where do you source the patches from? I assume that it depends on the patch, but for updates like this PR, it is mostly own work?

Was there ever an effort to try to upstream the patches?

[luk1337]

Just curious: How do you manage all the patches? There's quite a number of them in nmeum/android-tools. Does the update procedure look something like this?

• remove patches which are already part of the newer release
• if a patch no longer applies and the code hasn't changed much, make the minimum ammount of changes to the patch to make it apply
• if a patch no longer applies and the code has changed, assess whether the patch is still needed; if it is, rework it
• if there are compilation issues in the CI test matrix (or some other test environments), add patches to fix these

pretty much, yes.

Where do you source the patches from? I assume that it depends on the patch, but for updates like this PR, it is mostly own work?

most of them seem downstream.

Was there ever an effort to try to upstream the patches?

no idea, from my experience upstreaming anything to AOSP was historically annoying and nowadays when AOSP is developed in private and you have to beg for them to reupload your patch to internal gerrit in hopes of someone reviewing it without giving you any feedback whether it's merged or rejected whatsoever, I just don't see a reason to bother.

[luk1337]

also RE: upstreaming, I sent https://sourceforge.net/p/linux-f2fs/mailman/message/59308559/ just now.

[salvogiangri]

Looks good to me, I still don't understand why #158 happens. Reverting 5da4e524 does not work anymore and will cause make_f2fs to crash