Conversation
| CHECK_THROWS( parse( "E+a123", position ) ); | ||
| CHECK_THROWS( parse( "D-a123", position ) ); | ||
| CHECK_THROWS( parse( "D+a123", position ) ); | ||
| CHECK_THROWS( parse( "E -123", position ) ); |
Contributor
There was a problem hiding this comment.
These are valid in Fortran :)
| CHECK_THROWS( parse( "D +123", position ) ); | ||
|
|
||
| CHECK_THROWS( parse( "- a3", position ) ); | ||
| CHECK_THROWS( parse( "- ", position ) ); |
Contributor
There was a problem hiding this comment.
Fortunately, this one is not valid. I did confirm that because I was concerned.
…e tests to that effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to allow for cases where spaces are used instead of '0' in the exponent. This change is made in response to some ENDF files (e.g. the IRDFF-II files) still using constructs like '1.2345E+ 1' as values (these appear to be remnants from older fortran standards).
These changes clean up some code and add the possibility of reading the following special cases:
As per the current standard procedures, this will go into develop first.
These changes were tested on the entire ENDF/B-VIII.0 library (using the develop version of ENDFtk) to ensure no regression. Some additional changes were made following these tests.