Feature: barcodescanner for quick carb entry of processed food#874
Feature: barcodescanner for quick carb entry of processed food#874EJM0 wants to merge 86 commits intonightscout:devfrom
Conversation
kingst
left a comment
There was a problem hiding this comment.
I'm concerned about the use of AI/ML here without any sort of design doc. Given that insulin is a dangerous hormone, anything that uses AI/ML, especially via cloud services, should have a well articulated safety and security discussion.
I love the initiative of this feature, but from a quick glance at the code I'm less enthusiastic about the maintenance overhead given the benefit vs complexity that I can see. Long term I'd like to see Trio move toward no meal announcements vs tools to help with meal announcements, but that's just my own personal opinion.
Architecturally, have you considered using a separate app for this and interfacing with Trio via a universal link or some other IPC mechanism?
As a concrete next step I'd like to suggest starting with a short design document.
cee3256 to
de8d1d3
Compare
|
I thought about implementing it as a separate app, but with that would come unnecessary complications. |
1ffbf70 to
de8d1d3
Compare
Ohne.Titel.mp4 |
|
At this time, we will not be accepting any PRs that require linking an LLM to use them. Please strip the AI parts out. Thank you. |
|
Hi @MikePlante1 , does that mean specifically using LLM for dosing? If yes, I stripped that out of the code. The only "ai" used here is openfoodfact-extractor. Which is only used for extracting nutritional labels from food that is not covered by the barcode db. Therefore, it does not do any carb predictions and also not falling under this case. |
trim.40FE5CFD-C312-402C-8377-89FACF10484A.MOVCurrent state |
To quote the comment you linked from @dnzxy :
So please strip it out for this PR. If this policy changes in the future, you'd be welcome to PR it again. |
|
Okay I'll do so :) |
|
Ready @dnzxy, |
|
Sorry, very busy with life recently and attempting to get dev to main. |
|
Okay, good to hear. Looking forward for the big release:) 🍾 |
-add quantity selctors for liquids if only per100ml data is present -refoctor animaton and apperans of amount multiplicator -reduce height of list components
- Add search bar and list to list view - Separate search bar and search list
separate search bars
…reduce data usage
Barcode Scanner and Search Bar using OpenFoodFacts DB
Search Bar (Treatment View & List View)
I recommend logging in via OpenFoodFacts because text search is currently rate-limited for anonymous users, although the barcode API is not affected. By logging in, users can also correct incorrect data, improving their own results while contributing to the quality of the OpenFoodFacts database. Justifying the added usage to their service.
Barcode Scanner
List View (Items Added to Meal)
Edit View of Items
Treatmentview with added item
Settings