Support custom metrics and trace labels provided from the context#291
Support custom metrics and trace labels provided from the context#291nhatthm wants to merge 1 commit into
Conversation
ec77495 to
9897125
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 23 +1
Lines 1038 1075 +37
=========================================
+ Hits 1038 1075 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@manishdangi98 could you please confirm if this matches your expectations? |
9897125 to
32ef0f0
Compare
|
I think we can already add custom labels from context to "trace" by using "TraceQuery" option. My idea was to add an option similar for "metrics" too, and I'm currently using this patch to solve my problem. I think this PR doesn't solve this issue described in #222 , because we cannot set labels from the "query". |
Description
Support custom metrics and trace labels provided from the context